Site Assessment project persistence #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torage. document the local storage issues. fix observable errors. dev_tips doc update
…ethod, load saved jobs
|
❌ Code formatting check failed. Please run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persist Site Assessment project state.
:deep()ever worked)projectIdSignificant Changes
I disagree with reverting to default project state when a project is found to be invalid. This is no different than the user creating a new project. Also, the fallback to local storage was not safe (all project shared same key, no date checks, etc). So instead invalid project state shows an error - either developers implement a migration to fix that project state, or users just move on and create a new project.
Limitations/TODO
Currently, job layer is restored if job succeeded. Ideally, reload would attach to in-progress job as well. Doing this requires some cleanup of related code: #233
Also checking job
cache_validwill be done in:#193