Skip to content

Conversation

@vitalij-vladimirov
Copy link
Contributor

@vitalij-vladimirov vitalij-vladimirov commented Dec 7, 2025

Description

  1. Remove moxio/php-codesniffer-sniffs.
    • It looks like it is not maintained anymore, last update was 18 months ago and it conflicts with squizlabs/php_codesniffer and slevomat/coding-standard.
  2. Remove all Moxio rules. Would be nice to replace them with something else, but, from what I see, they were not very critical.
  3. Update all other dependencies to newest versions compatible with PHP 8.5.
  4. Replace deprecated SlevomatCodingStandard.TypeHints.UnionTypeHintFormat with SlevomatCodingStandard.TypeHints.DNFTypeHintFormat.
  5. Refactor OpaySniffs/Sniffs/Classes/ForbiddenClassesSniff.php due to deprecated functions used in previous versions:
    • Copy original ForbiddenClassesSniff ignoring all changes in previous Opay version.
    • Do only required changes without full class refactoring.
    • Screenshot of working Sniff added below.
  6. Add docker-compose.yml and Makefile to allow running composer install inside of container instead of having PHP on localhost.
    • Adding .env with config DOCKER_IMAGE: ghcr.io/opay/base-php-local:8.5 allows using internal docker image, otherwise composer must be installed alongside with default php:8.5-fpm-alpine.
  7. Fix lint command
    • Wrong Examples directory path
    • Useless allow-unsupported-php-version command (probably, it was useful before upgrade)
  8. Upgrade PHP version to 8.5 in GitHub linting workflow

New tag should be v1.6.0 or even v2.0.0, since this upgrade contains Moxio deprecation.

image

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Tech. debt (non-breaking code improvement or technical functionality)

Code testing

  • Manual testing done

Code quality

  • My changes generate no new warnings or errors in IDE
  • I have performed a self-review of my own code before selecting reviewers
  • My code does not smell (I am sure about my code quality, I did the best I could)

@Kilmanas Kilmanas merged commit 19cf1c7 into opay:master Dec 8, 2025
1 check passed
@vitalij-vladimirov vitalij-vladimirov deleted the Upgrade-to-PHP-8.5 branch December 8, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants