Skip to content

APP-100: Replace PHP Linting Tools PHP_CS_FIXER_IGNORE_ENV config #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PauliusOpay merged 3 commits into from
Jul 24, 2025
Merged

APP-100: Replace PHP Linting Tools PHP_CS_FIXER_IGNORE_ENV config #15

PauliusOpay merged 3 commits into from
Jul 24, 2025

Conversation

@PauliusOpay
Copy link
Contributor

@PauliusOpay PauliusOpay commented Jul 24, 2025 •
edited
Loading

Description

Added --allow-unsupported-php-version=yes config when running php-cs-fixer. This is step 1 of this task. PHP_CS_FIXER_IGNORE_ENV must be removed from docker-compose.yml of each app

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Tech. debt (non-breaking code improvement or technical functionality)

Code testing

  • Manual testing done

Code quality

  • My changes generate no new warnings or errors in IDE
  • I have performed a self-review of my own code before selecting reviewers
  • My code does not smell (I am sure about my code quality, I did the best I could)

@PauliusOpay PauliusOpay marked this pull request as draft July 24, 2025 08:26
@PauliusOpay PauliusOpay marked this pull request as ready for review July 24, 2025 08:40
@PauliusOpay PauliusOpay requested review from a team, Arturas-B112, Kilmanas, ignasopay, vaivasav and vitalij-vladimirov and removed request for a team July 24, 2025 08:40
@PauliusOpay PauliusOpay merged commit c21c5a0 into master Jul 24, 2025
1 check passed
@PauliusOpay PauliusOpay deleted the APP-100_Replace-PHP-Linting-Tools-PHP_CS_FIXER_IGNORE_ENV-config branch July 24, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaivasav vaivasav vaivasav approved these changes

@ignasopay ignasopay Awaiting requested review from ignasopay ignasopay was automatically assigned from opay/2nd-gen-apps-inventors

@vitalij-vladimirov vitalij-vladimirov Awaiting requested review from vitalij-vladimirov vitalij-vladimirov was automatically assigned from opay/2nd-gen-apps-inventors

@Kilmanas Kilmanas Awaiting requested review from Kilmanas Kilmanas was automatically assigned from opay/2nd-gen-apps-inventors

@Arturas-B112 Arturas-B112 Awaiting requested review from Arturas-B112 Arturas-B112 was automatically assigned from opay/2nd-gen-apps-inventors

Assignees

@ignasopay ignasopay

@vitalij-vladimirov vitalij-vladimirov

@vaivasav vaivasav

@Kilmanas Kilmanas

@Arturas-B112 Arturas-B112

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@PauliusOpay @vaivasav @ignasopay @vitalij-vladimirov @Kilmanas @Arturas-B112