Skip to content

fix: stdout/stderr/stdin not close when copy finished #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ihexon merged 1 commit into from
May 12, 2025
Merged

fix: stdout/stderr/stdin not close when copy finished #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pkg/provider/ffmpeg/stubber.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,25 @@ func (l *Stubber) Run(ctx context.Context, target string, args, envs []string) e
// Copy cmd stdout to ssh session
go func() {
_, _ = io.Copy(l.Session, stdOut)
logrus.Infof("Copy cmd stdout to ssh session's stdout finished")
_ = stdOut.Close()
}()

// Copy cmd stderr to ssh session's stderr
go func() {
_, _ = io.Copy(l.Session.Stderr(), stdErr)
logrus.Infof("Copy cmd stderr to ssh session's stderr finished")
_ = stdErr.Close()
}()

// Copy stdin from session to cmd stdin
go func() {
_, _ = io.Copy(stdIn, l.Session)
_, err := io.Copy(stdIn, l.Session)
if err != nil {
logrus.Errorf("io.Copy(stdIn, l.Session) error: %v", err)
}
logrus.Infof("Copy stdin from session to cmd stdin finished")
_ = stdIn.Close()
}()

if err = cmd.Wait(); err != nil {
Expand Down