fix(scripts): replace deprecated file.path with parentPath#211
fix(scripts): replace deprecated file.path with parentPath#211BlackHole1 merged 1 commit intomainfrom
Conversation
Node.js deprecated Dirent.path in favor of Dirent.parentPath. Update the download script to use the new property name. Signed-off-by: Kevin Cui <bh@bugs.cc>
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThe change modifies the path resolution mechanism in the download script. Specifically, the chmod destination path computation is updated to use Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the download script to use the new Dirent.parentPath property instead of the deprecated Dirent.path property, ensuring compatibility with current Node.js versions.
- Updated property name from
file.pathtofile.parentPathto use the non-deprecated API
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Node.js deprecated Dirent.path in favor of Dirent.parentPath. Update the download script to use the new property name.