Conversation
Summary by CodeRabbit
WalkthroughThis PR adds release notes for v0.1.7 and updates the project version in pyproject.toml. The changelog documents the introduction of a new LaTeX rendering pathway using mathml2latex to replace XSLT-based MathML processing, bug fixes for mixed original/translated text in APPEND_BLOCK mode containing inline MathML, and a fix ensuring user_prompt is included in translations. The mathml2latex dependency (>=0.2.12, <0.3.0) is added as a new requirement, and legacy XSLT stylesheets are removed. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/changelog/v0.1.7.md`:
- Around line 16-47: Replace bare URLs with Markdown links in the changelog
entries that currently read "Related PR: https://..." and "Related Issue:
https://..."; specifically update the "Related PR:
https://github.com/oomol-lab/epub-translator/pull/121", "Related PR:
https://github.com/oomol-lab/epub-translator/pull/120", and "Related Issue:
https://github.com/oomol-lab/epub-translator/issues/119" lines to use the
Markdown link format (e.g., Related PR:
[`#121`](https://github.com/oomol-lab/epub-translator/pull/121)), keeping the
existing label text like PR/Issue numbers to preserve readability and
consistency with the other inline references such as "Fixed issue [`#119`](...)".
Comment on lines
+16
to
+47
| Related PR: https://github.com/oomol-lab/epub-translator/pull/121 | ||
|
|
||
| ## 🐛 Bug Fixes | ||
|
|
||
| ### Fixed Mixed Text with Inline Math Formulas (#120) | ||
|
|
||
| Fixed issue [#119](https://github.com/oomol-lab/epub-translator/issues/119) where paragraphs containing inline MathML formulas (e.g., `<math display="inline">`) would generate mixed original and translated text instead of properly separated bilingual paragraphs in `APPEND_BLOCK` mode. | ||
|
|
||
| **Technical Improvements:** | ||
| - Introduced `find_block_depth()` function (now part of public API in `epub_translator.segment`) | ||
| - Replaced string-based `is_inline_tag` with element-based `is_inline_element` for better detection | ||
| - Enhanced display attribute checking for MathML elements | ||
| - Improved inline element hierarchy evaluation | ||
|
|
||
| Related PR: https://github.com/oomol-lab/epub-translator/pull/120 | ||
| Related Issue: https://github.com/oomol-lab/epub-translator/issues/119 | ||
|
|
||
| ### Fixed Missing User Prompt (#118) | ||
|
|
||
| Fixed issue [#117](https://github.com/oomol-lab/epub-translator/issues/117) where the `user_prompt` parameter was not being included in the translation template. The prompt is now properly wrapped in `<rules>` tags and passed to the LLM. | ||
|
|
||
| **Template Change:** | ||
| ```jinja | ||
| {% if user_prompt -%} | ||
| <rules> | ||
| {{ user_prompt }} | ||
| </rules> | ||
| {% endif -%} | ||
| ``` | ||
|
|
||
| Related PR: https://github.com/oomol-lab/epub-translator/pull/118 | ||
| Related Issue: https://github.com/oomol-lab/epub-translator/issues/117 |
There was a problem hiding this comment.
Use Markdown links instead of bare URLs.
Switching the raw PR/issue URLs to Markdown links improves readability and consistency in the changelog.
📝 Suggested edit
-Related PR: https://github.com/oomol-lab/epub-translator/pull/121
+Related PR: [`#121`](https://github.com/oomol-lab/epub-translator/pull/121)
-Related PR: https://github.com/oomol-lab/epub-translator/pull/120
-Related Issue: https://github.com/oomol-lab/epub-translator/issues/119
+Related PR: [`#120`](https://github.com/oomol-lab/epub-translator/pull/120)
+Related Issue: [`#119`](https://github.com/oomol-lab/epub-translator/issues/119)
-Related PR: https://github.com/oomol-lab/epub-translator/pull/118
-Related Issue: https://github.com/oomol-lab/epub-translator/issues/117
+Related PR: [`#118`](https://github.com/oomol-lab/epub-translator/pull/118)
+Related Issue: [`#117`](https://github.com/oomol-lab/epub-translator/issues/117)🤖 Prompt for AI Agents
In `@docs/changelog/v0.1.7.md` around lines 16 - 47, Replace bare URLs with
Markdown links in the changelog entries that currently read "Related PR:
https://..." and "Related Issue: https://..."; specifically update the "Related
PR: https://github.com/oomol-lab/epub-translator/pull/121", "Related PR:
https://github.com/oomol-lab/epub-translator/pull/120", and "Related Issue:
https://github.com/oomol-lab/epub-translator/issues/119" lines to use the
Markdown link format (e.g., Related PR:
[`#121`](https://github.com/oomol-lab/epub-translator/pull/121)), keeping the
existing label text like PR/Issue numbers to preserve readability and
consistency with the other inline references such as "Fixed issue [`#119`](...)".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.