-
Notifications
You must be signed in to change notification settings - Fork 118
RFC: generating the PTZ specs with Github actions #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
|
Looks good 👍 |
That has not been touched yet. The first commit only changed |
if these are the formulas that you are referring to then it renders well. I have seen what @venki5685 reported and was concerned until I read your response. |
|
I am observing the rendered content at this URL. None of the formulas seem to render correctly, neither if the SVG or with embedded MathML
The equation surrounded with the red box is the one I changed, that should show this svg image But the equation in the green box is broken as well, and this has not being touched by my proposal. |
still a bit to look into then :) |
|
Small update. the online preview still has the the old code with embedded MathML. I am trying to understand why it did not update. (I rebased to squash branch to have just one commit, this may be the reason why it is not updating any more) |
|
With the laterst PR it looks good on my side |
doc/equations/README.md
Outdated
| @@ -0,0 +1,7 @@ | |||
| # Equation images | |||
|
|
|||
| This foder holds all the equations used in the specification documents. This is necessary because Apache Fop has issue rendering MathML, which is used the PTZ Service specifications. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo --> folder
|
@ocampana-videotec I am seeing no page separation , document contents and the Formulas not rendering. I was comparing the 25.06 PTZ Spec with the Generated on on the Dev Rendering.
Should I be looking at a different doc? |
The formulas should be a bit lower than that image, try to scroll down to §5.7.1.4. About the page breaks: they are never present when you look at the branches on developer.onvif.org . They are added when generating the PDF file. |
Sorry @ocampana-videotec this is a screen shot from 25.06 containing formulas on that page and on the 25.12 version has them also (I take it that version was generated in the old way.)
r-attachments/assets/28a7cd6b-02bc-47a6-a0b9-7eed262fea19" />
t; />
|
a04b532 to
c2c78c6
Compare
|
I completed updating all the equations in the document. There is still pending the choice of the size of the equations. which is purely cosmetical and I think we can defer this to our next F2F meeting. Please, review both the online preview on developer.onvif.org and the attached generated file (it does not have the draft watermark, to avoid rendering issues) ONVIF-PTZ-Service-Spec-PR700.pdf Beyond the cosmetical issue, for me it is ready for inclusion in 26.06 |
|
Propose to defer the change to 26.06 and generate the 25.12 document using oxygen. The formula rendering looks nice but the large size and position issues make most very hard to read. |
I fully agree, in fact this PR is tagged 26.06 , to have the time to agree on the appearance of the formulas. |








As we are all aware, the PTZ Service specs cannot be generated with the same tools as for the other documents, but we have to rely on an external editor.
To allow generating the documents with Github actions, while preserving the possibility to edit the equations without a graphic editor, in this PR I propose to use intermediate
.svgfiles generated form MathML, so that the pdf for the PTZ service can be generated.Workflow
.xmlfile under doc/equations, like this one.svgfile