This repository was archived by the owner on Nov 23, 2022. It is now read-only.
Open
Conversation
kshna
commented
Oct 4, 2022
| export * from './CategorySelect' | ||
| export * from './ImageUpload' | ||
| export * from './PageHelmet' | ||
| export * from './SignModal' No newline at end of file |
Author
There was a problem hiding this comment.
export * from './TagSearchingBlock' is missing here
| @@ -1,10 +1,9 @@ | |||
| // Local files | |||
| import { TitleResponseData, CategoryResponseData } from '@/@types/api' | |||
| import { TitleResponseData } from '@/@types/api' | |||
Author
There was a problem hiding this comment.
corresponding "TagResponseData" should be added in place of CategoryResponseData
| export interface FeedPageInitials { | ||
| titleData: TitleResponseData, | ||
| categoryData: CategoryResponseData, | ||
| featuredEntry: string, |
| @@ -1,5 +1,5 @@ | |||
| // Local files | |||
| import { CategoryResponseData, TitleResponseData, EntryResponseData} from '@/@types/api' | |||
| import { TitleResponseData, EntryResponseData} from '@/@types/api' | |||
Author
There was a problem hiding this comment.
TagResponseData should be added here
| export interface FeedHeaderProps { | ||
| accessToken: string, | ||
| categoryData: CategoryResponseData, | ||
| titleData: TitleResponseData, |
Author
There was a problem hiding this comment.
TagResponseData should be added here as well
| const handleDeSelect = (tag: string) => { | ||
| const updatedList = tagValue.filter(value => value !== tag) | ||
| setTagValue(updatedList) | ||
| } |
Author
There was a problem hiding this comment.
import TagSearchingBlock to use all the tag handles here
|
|
||
| if (titleNotFound) return <NotFoundPage /> | ||
| if (!entryList || !title || !category || (!averageTitleRate && averageTitleRate !== 0)) return <PageLoading /> | ||
| if (!entryList || !title || (!averageTitleRate && averageTitleRate !== 0)) return <PageLoading /> |
| ) | ||
| }) | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
pls use the component FeedHeader for handleTagsView
| } | ||
|
|
||
| async searchTag(searchValue: string): Promise<{ tags: TagsEntity[] }> { | ||
| const [tags] = await this.findAndCount({ |
Author
There was a problem hiding this comment.
pls use find instead of findAndCount here
| @ApiProperty({ | ||
| required: false, | ||
| example: '507f1f77bcf86cd799439011', | ||
| example: '"electronics", "phone", "samsung"' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.