Added xApp policy ratio parameters to the slice config and updated api #227
+1,651
−218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>
|
test this please |
|
retest this please |
gab-arrobo
requested changes
Dec 29, 2023
| title: application-id | ||
| type: string | ||
| x-go-type: ListKey | ||
| x-yang-type: application-id |
There was a problem hiding this comment.
Because this new variable, the Test_ValidateRequestGivesError test is failing. Try to make sure that your changes do not break the code (and tests)
diff --git a/pkg/toplevel/server/validation_test.go b/pkg/toplevel/server/validation_test.go
index 60cb145..6dfc17b 100644
--- a/pkg/toplevel/server/validation_test.go
+++ b/pkg/toplevel/server/validation_test.go
@@ -65,7 +65,8 @@ Schema:
"maxLength": 1024,
"minLength": 1,
"title": "description",
- "type": "string"
+ "type": "string",
+ "x-yang-type": "description"
}
Value:
SeanCondon
requested changes
Jan 2, 2024
SeanCondon
left a comment
SeanCondon
left a comment
There was a problem hiding this comment.
It should be possible to run make generated and then make test and not get any errors.
I think there is some technical debt on master because of link rot or module rot that will have to be fixed.
Due to compiler version change the target values are not populated as expected. It causes few tests to fail due to tagrget mismatch. Updated the tests to resolve the same. Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added new parameters like policy ratios to the slice configuration which will be pushed to the RAN( xApp).
Also we added an endpoint parameter to the site which is used to configure the xApp endpoint URL
Updated api repo using the latest aether-models.