Read VERSION file contents when bumping version #16
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Bavier <andybavier@gmail.com>
Signed-off-by: Andy Bavier <andybavier@gmail.com>
gab-arrobo
approved these changes
Jan 23, 2026
gab-arrobo
left a comment
gab-arrobo
left a comment
There was a problem hiding this comment.
LGTM.
@andybavier, do you think this is something that we should also integrate into the omec-project organization?
SeanCondon
approved these changes
Jan 23, 2026
Contributor
Author
Maybe. Let me get the publish pipeline fully working and tested for onosproject and then we can look at pulling any relevant changes over to omec-project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the contents of the VERSION file directly prior to bumping the version. It is assumed that the pipeline has already validated the VERSION file format using the
tag-githubworkflow.The idea is to decouple the contents of the VERSION file from the output of
tag-github. The former is expected to contain a semver (e.g., 1.2.3) while the latter outputs a tag that is used for the release / Docker images. By convention some repos expect the tag to be prefixed with "v", and therefore the tag is not always identical to the VERSION.Insights > Dependency graph > Dependents shows that this workflow is only used by two other repos. I will update their workflows after this PR merges.