Skip to content

fix(plugin): add MCP readiness gate and reload-plugins step#190

Merged
onlycastle merged 5 commits intomainfrom
fix/plugin-mcp-readiness-gate-20260326
Mar 27, 2026
Merged

fix(plugin): add MCP readiness gate and reload-plugins step#190
onlycastle merged 5 commits intomainfrom
fix/plugin-mcp-readiness-gate-20260326

Conversation

@onlycastle
Copy link
Copy Markdown
Owner

Summary

  • Adds MCP Readiness Gate to bp-setup wizard — retries MCP tool calls (3 attempts with backoff) when the server is still starting after install or /reload-plugins
  • Adds explicit /reload-plugins step to README installation guide so users know to reload before first-time setup

Changes

  • fix(plugin): add MCP readiness gate to bp-setup wizard
  • docs: add reload-plugins step to installation guide

Test Plan

  • Install plugin fresh, run bp setup before MCP is ready — verify retry logic and error messages
  • Run bp setup after MCP is ready — verify gate passes on first attempt
  • Follow README install steps end-to-end — verify /reload-plugins step is clear

Generated with Claude Code using /ship-it

onlycastle and others added 2 commits March 26, 2026 20:33
The MCP server may still be starting after install or /reload-plugins.
Add a retry mechanism (3 attempts with backoff) before proceeding with
the setup wizard, plus clearer error guidance when tools are unreachable.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Users need to run /reload-plugins after installing so Claude Code
picks up the new MCP server and skills before first-time setup.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@onlycastle
Copy link
Copy Markdown
Owner Author

Code Review

Found 5 issues:

  1. Step 3 references Step 2 data with no fallback — Step 2 (scan_sessions) is now non-critical, but Step 3 unconditionally says "Display the project list from Step 2". When Step 2 fails, the LLM has no allProjects data to display, leading to undefined behavior in project selection.

  2. docs/agent/ not updated for pipeline change — CLAUDE.md requires updating docs/agent/ docs when the pipeline changes. The MCP Readiness Gate is a new pre-phase in bp-setup, but neither PLUGIN.md nor TROUBLESHOOTING.md reflect this.

  3. Important Notes contradicts new Step 2 behaviorLine 248 says "Never skip Step 2 — it confirms the plugin works" and line 251 lists only "Steps 4, 5 are non-critical", but the PR makes Step 2 failure non-critical. These lines now contradict the new behavior.

  4. README Troubleshooting conflicts with /reload-plugins — The new Quick Start step says to run /reload-plugins after install, but the Troubleshooting table still says "Restart Claude Code after plugin install" for the same MCP-not-starting scenario.

  5. Pre-Check "Otherwise" branch is unreachableLine 45: "Otherwise, call get_user_prefs now" can never fire. The Readiness Gate either succeeds (reuse branch applies) or exits the wizard entirely (step 4). There is no path to Pre-Check without a successful prior call.

Generated with Claude Code

If useful, react with a thumbs-up. Otherwise, thumbs-down.

onlycastle and others added 3 commits March 26, 2026 20:41
- Step 3: retry scan_sessions or offer defaults when Step 2 failed
- Pre-Check: remove unreachable "Otherwise" branch (gate always
  succeeds or exits)
- Important Notes: list Step 2 as non-critical alongside Steps 4, 5

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…TING.md

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@onlycastle onlycastle merged commit b49efcd into main Mar 27, 2026
1 check passed
@onlycastle onlycastle deleted the fix/plugin-mcp-readiness-gate-20260326 branch March 27, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant