Skip to content

Add setup to sell item and use generic types #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshuahannan merged 4 commits into from
Aug 4, 2025
Merged

Add setup to sell item and use generic types #111

joshuahannan merged 4 commits into from
Aug 4, 2025

Conversation

@joshuahannan
Copy link
Member

@joshuahannan joshuahannan commented Jul 24, 2025 •
edited
Loading

Closes #104
Closes #95

  • Adds setup storefront logic to sell item transactions so that they don't have to run a separate setup transaction
  • Use generic token types in the V2 transactions so developers don't have to replace with their own specific types
  • Update some import placeholders

sisyphusSmiling
sisyphusSmiling approved these changes Aug 2, 2025
View reviewed changes
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Made a couple minor suggestions for consistent camel case - there are a couple places where pascal case is used.

@joshuahannan joshuahannan merged commit d70cf3f into main Aug 4, 2025
2 checks passed
@joshuahannan joshuahannan deleted the josh/small-enhancements branch August 4, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvdtf nvdtf Awaiting requested review from nvdtf

1 more reviewer

@sisyphusSmiling sisyphusSmiling sisyphusSmiling approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add storefront configuration to the sell item transaction Use general token interface types and V2 standards features in storefront transactions

3 participants

@joshuahannan @sisyphusSmiling