Allow any address for custom networks #2240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasefleming
requested review from
Kay-Zee,
bjartek,
janezpodhostnik,
jribbink,
mfbz and
nvdtf
as code owners
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
jribbink
approved these changes
Dec 29, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jribbink
reviewed
Dec 29, 2025
Comment on lines
+67
to
+69
| // For custom networks, we can't validate the address format without knowing the chain ID, | ||
| // so we allow all addresses | ||
| return true |
Contributor
There was a problem hiding this comment.
I feel like we could try to use something like GetNetworkParameters chain ID for some stronger validation here in the future, but probably not strictly necessary for this fix.
turbolent
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #???
Description
For contributor use:
masterbranchFiles changedin the Github PR explorer