FLOW-10 - Validate betaRef parameter in createYieldVaultManager #146
+205
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pre-condition to createYieldVaultManager that invokes FlowYieldVaultsClosedBeta.validateBeta to verify the betaRef is valid, making the Beta gating behavior explicit and consistent with other Beta-gated methods. Addresses Quantstamp audit finding FLOW-10. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This was referenced Jan 13, 2026
liobrasil
changed the title
|
Please can you a add a test for this change? ty |
turbolent
reviewed
Jan 21, 2026
| access(all) let capID: UInt64 | ||
| access(all) let isRevoked: Bool | ||
|
|
||
| init(_ capID: UInt64, _ isRevoked: Bool) { |
Member
There was a problem hiding this comment.
Here and below: Use the argument label to document what the parameters mean, they make the call-sites easier to understand:
Suggested change
| init(_ capID: UInt64, _ isRevoked: Bool) { | |
| init(capID: UInt64, isRevoked: Bool) { |
| /// Issue a capability from the contract/deployer account and record its ID | ||
| access(contract) fun _issueBadgeCap(_ addr: Address): Capability<auth(Beta) &BetaBadge> { | ||
| let p = self._badgePath(addr) | ||
| let cap: Capability<auth(Beta) &BetaBadge> = |
Member
There was a problem hiding this comment.
Type annotation is unnecessary and can be inferred
Suggested change
| let cap: Capability<auth(Beta) &BetaBadge> = | |
| let cap = |
Comment on lines
+114
to
+115
| if info.isRevoked { | ||
| assert(info.isRevoked, message: "Beta access revoked") |
Member
There was a problem hiding this comment.
This assert is a no-op, in this branch info.isRevoked is always true
|
|
||
| /// Per-user badge storage path (under the *contract/deployer* account) | ||
| access(contract) fun _badgePath(_ addr: Address): StoragePath { | ||
| return StoragePath(identifier: "FlowYieldVaultsBetaBadge_".concat(addr.toString()))! |
Member
There was a problem hiding this comment.
Use string templates:
Suggested change
| return StoragePath(identifier: "FlowYieldVaultsBetaBadge_".concat(addr.toString()))! | |
| return StoragePath(identifier: "FlowYieldVaultsBetaBadge_\(addr.toString())")! |
|
|
||
| /// Ensure the admin-owned badge exists for the user | ||
| access(contract) fun _ensureBadge(_ addr: Address) { | ||
| let p = self._badgePath(addr) |
Member
There was a problem hiding this comment.
Here and below: Use descriptive variable names:
Suggested change
| let p = self._badgePath(addr) | |
| let path = self._badgePath(addr) |
Comment on lines
+27
to
+29
| access(all) view fun getOwner(): Address { | ||
| return self.assignedTo | ||
| } |
Member
There was a problem hiding this comment.
Maybe just make assignedTo access(all) and remove this unnecessary getter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
createYieldVaultManagerthat callsFlowYieldVaultsClosedBeta.validateBetaQuantstamp Audit Finding
FLOW-10: Unused betaRef Parameter in YieldVaultManager Creation (Undetermined)
The
createYieldVaultManagerfunction accepts abetaRefparameter but did not use it in the function body. The recommendation was to invokeFlowYieldVaultsClosedBeta.validateBetainside the function for consistency with other Beta-gated methods.Test plan
createYieldVaultManagerrejects invalid betaRefCloses #141
🤖 Generated with Claude Code