[REF] subscription_oca: add subscription date range to invoice#26
Open
gbrito wants to merge 1 commit intoonesteinbv:16.0from
Open
[REF] subscription_oca: add subscription date range to invoice#26gbrito wants to merge 1 commit intoonesteinbv:16.0from
gbrito wants to merge 1 commit intoonesteinbv:16.0from
Conversation
Member
|
Can you rebase your branch, please? git fetch onestein 16.0
git rebase onestein/16.0 |
gbrito
force-pushed
the
16.0-subscription_oca_range
branch
from
67fc1ed to
a022209
Compare
tarteo
reviewed
Apr 17, 2025
| self.ensure_one() | ||
| if self.account_invoice_ids_count == 0: | ||
| start_date = self.date_start | ||
| end_date = self.recurring_next_date |
Member
There was a problem hiding this comment.
Shouldn't this be self._calculate_recurring_next_date(self.date_start)
Now the period of the first invoice is:
But the next is
I would expect the first to be 04/17/2025 and 05/17/2025
The problem could also be that recurring_next_date should be updated when date_start is changed or the template.
gbrito
force-pushed
the
16.0-subscription_oca_range
branch
from
a022209 to
cc2701b
Compare
gbrito
force-pushed
the
16.0-subscription_oca_range
branch
from
cc2701b to
3d1bc60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.