Open
Conversation
pre-commit fix
ByteMeAsap
force-pushed
the
16.0-add-website_sale_disable_shop
branch
from
8013104 to
aff3d0d
Compare
pre-commit fix
tarteo
force-pushed
the
16.0-add-website_sale_disable_shop
branch
from
aff3d0d to
51f26ec
Compare
tarteo
reviewed
Apr 17, 2025
Member
tarteo
left a comment
tarteo
left a comment
There was a problem hiding this comment.
Couldn't test it thoroughly because there's an issue (which I'm looking into), but these are the things I found for now:
| if path == "/shop" or Path("/shop") in Path(path).parents: | ||
| if path == "/shop/cart" and request.params.get("type") == "popover": | ||
| return None | ||
| return request.redirect("/") |
Member
There was a problem hiding this comment.
IMO it's better to return a 404 here.
Contributor
Author
There was a problem hiding this comment.
yes, sounds good !!
Have removed the check for popover shop/cart as well
Contributor
Author
There was a problem hiding this comment.
Added an additional thing for /shop/cart/quantity as it was giving a client issue
…-website_sale_disable_shop
Pre-commit fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.