Conversation
…without application linked
There was a problem hiding this comment.
Pull request overview
This PR extends the ArgoCD website/portal experience to support reseller workflows, including managing end customers and ordering applications on a customer’s behalf, while refactoring reseller-related data structures and access rules across modules.
Changes:
- Add a reseller customer portal (list/detail/create/edit/archive) and reseller-specific signup/order flow (select self vs existing customer).
- Refactor reseller/product access logic and tighten portal visibility rules for products/applications/domains.
- Rename ArgoCD attribute value field (
argocd_name→argocd_value) and adjust deployment/config rendering accordingly.
Reviewed changes
Copilot reviewed 38 out of 41 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| argocd_website/tests/test_security.py | Minor test cleanup in security test. |
| argocd_website/templates/website.xml | Adds reseller customer selection in signup UI and carries customer_id through ordering flow. |
| argocd_website/templates/portal.xml | Portal home entry tweaks (icon + external links dropdown behavior). |
| argocd_website/templates/customer_portal.xml | New portal templates for reseller customer management. |
| argocd_website/static/src/js/portal.esm.js | Adds counters + signup form widget to show/hide customer selection UI. |
| argocd_website/static/src/img/application.svg | Adds/updates application icon asset. |
| argocd_website/security/ir_rule.xml | Updates product/app/domain rules and adds reseller customer read rule. |
| argocd_website/security/ir_model_access.xml | Adds portal access for domain scope, partner, and country models. |
| argocd_website/controllers/main.py | Adds reseller target/customer validation and wiring for customer_id through order/signup. |
| argocd_website/controllers/customer.py | New controller implementing reseller customer CRUD-like flows via portal. |
| argocd_website/controllers/init.py | Registers new customer portal controller. |
| argocd_website/manifest.py | Includes customer portal templates. |
| argocd_website/README.md | Updates module documentation and roadmap to include reseller customer flows. |
| argocd_sale/views/res_partner_view.xml | Adds reseller fields and a Resellers menu/action in the backend. |
| argocd_sale/views/product_template.xml | Adjusts product form and adds “Application” search filter + menu/action. |
| argocd_sale/views/product_attribute_view.xml | Updates attribute value field shown in list (argocd_value). |
| argocd_sale/tests/test_integrity.py | Adds integrity tests for reseller constraints. |
| argocd_sale/tests/init.py | Registers new integrity tests. |
| argocd_sale/models/subscription.py | Adds main_partner_id and reseller end-customer constraint logic. |
| argocd_sale/models/sale_subscription_line.py | Uses end customer or reseller main partner for application naming; removes tag propagation. |
| argocd_sale/models/res_partner.py | Refactors reseller modeling (reseller/customer relationships) + constraints. |
| argocd_sale/models/product_template.py | Refactors reseller product restriction field and adds template/set consistency constraint. |
| argocd_sale/models/product_attribute_value.py | Renames ArgoCD value field to argocd_value. |
| argocd_sale/models/application_domain.py | Adds stored partner_id on domains for portal/security use. |
| argocd_sale/models/application.py | Uses main/end partner for app ownership and requires argocd_value for config rendering. |
| argocd_sale/models/init.py | Registers new model extension for application domains. |
| argocd_sale/migrations/18.0.1.0.1/pre-migrate.py | Migration to copy argocd_name → argocd_value. |
| argocd_sale/demo/res_partner_demo.xml | Demo reseller + customer linkage data. |
| argocd_sale/demo/product_template_demo.xml | Updates/extends demo products for reseller scenarios. |
| argocd_sale/manifest.py | Bumps module version and includes new demo data. |
| argocd_sale/README.md | Expands documentation to cover reseller hierarchy/constraints and attribute mapping. |
| argocd_deployer/views/application_view.xml | Improves domains editing layout on application form. |
| argocd_deployer/views/application_domain_view.xml | Adds list/search/action for domains (incl. reserved domains). |
| argocd_deployer/models/application_domain.py | Makes application_id optional to support reserved domains. |
| argocd_deployer/menuitems.xml | Adds a Domains menu entry and reorders configuration menu. |
| argocd_deployer/demo/application_template_demo.xml | Demo renaming/updates for application template. |
| argocd_deployer/demo/application_set_demo.xml | Replaces demo repository values with example placeholders. |
| argocd_deployer/README.md | Reworks/modernizes deployer README formatting and content. |
| .flake8 | Increases max-complexity threshold. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
[FIX] Typos
[FIX] record rule [FIX] Migration script
ByteMeAsap
reviewed
Feb 20, 2026
Contributor
ByteMeAsap
left a comment
There was a problem hiding this comment.
Just one small comment , rest everything looks great !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General:
Resellers flow:
Normal ordering flows (non-reseller users / public users) is untouched