Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nourmalaeb
approved these changes
Mar 5, 2026
Collaborator
nourmalaeb
left a comment
nourmalaeb
left a comment
There was a problem hiding this comment.
Left a note about color tokens, not to solve in this PR but something I can take a look at soon.
| variant: 'banner', | ||
| intent: 'warning', | ||
| class: { | ||
| root: 'border-primary-orange1 text-neutral-black [background:linear-gradient(rgba(255,255,255,0.92),rgba(255,255,255,0.92)),var(--color-primary-orange1)]', |
Collaborator
There was a problem hiding this comment.
Looks like this gradient is to tint the --color-primary-orange1 to the right shade... we should ideally use a color from our scale. But I checked the lightest orange in that scale and it's too dark. Our core color tokens should be updated, though not in this PR.
Collaborator
Author
There was a problem hiding this comment.
Great. I think we'll need to update the Figma token as well since it's using this gradient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds in a new component to @op/ui for an AlertBanner.
Storybook: https://apps-workshop-git-alert-banner-oneproject.vercel.app/?path=/docs/alertbanner--docs
