Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
96125aa
Add rubric template utilities, collapsible FieldConfigCard, and store…
nourmalaeb Feb 27, 2026
2e930c8
Add rubric editor UI with collapsible criterion cards and auto-save
nourmalaeb Feb 27, 2026
7750e29
Add translation keys for rubric editor UI to all language files
nourmalaeb Feb 27, 2026
8ba1a9c
Update rubric empty state to match ProposalCategories pattern
nourmalaeb Feb 27, 2026
6dd96fe
Fix rubric editor saving on initial page load
nourmalaeb Feb 27, 2026
f565771
Revert "Fix rubric editor saving on initial page load"
nourmalaeb Feb 27, 2026
532e439
Remove coming soon tag for users with rubric access
nourmalaeb Feb 27, 2026
559f636
Rewrite criterion card with Accordion primitives and remove dropdown …
nourmalaeb Feb 27, 2026
77844a7
Add confirmation modal when deleting a rubric criterion
nourmalaeb Feb 27, 2026
4bb3ae4
Make entire criterion header row trigger accordion expand/collapse
nourmalaeb Feb 27, 2026
2b18038
Show criterion name, type badge, and score in collapsed header
nourmalaeb Feb 27, 2026
cfd1ea7
Always show criterion name in header, fallback to 'New criterion'
nourmalaeb Feb 27, 2026
d365809
Update translations for revised score labels section
nourmalaeb Mar 2, 2026
146bc73
Remove default score labels for scored criteria
nourmalaeb Mar 2, 2026
057ba73
Fix score labels jumping between textareas on edit
nourmalaeb Mar 2, 2026
5bb2ea8
Fix score labels jumping: use score value instead of array index
nourmalaeb Mar 2, 2026
45aa385
Preserve scored config when switching criterion type and back
nourmalaeb Mar 2, 2026
99826ee
Move scored config caching from rubricTemplate into RubricEditorContent
nourmalaeb Mar 3, 2026
d8776a3
Hide coming soon on mobile
nourmalaeb Mar 3, 2026
95adf71
Adapt rubric editor to typed translations
nourmalaeb Mar 3, 2026
c130127
Fix label sorting
nourmalaeb Mar 3, 2026
ae0305d
Update styling
nourmalaeb Mar 3, 2026
ad97b3a
Error boundary and types
nourmalaeb Mar 3, 2026
3817060
Simplify
nourmalaeb Mar 3, 2026
ca411f4
reuse delete modal
nourmalaeb Mar 3, 2026
703f007
Revert feild config card changes
nourmalaeb Mar 3, 2026
d027689
format
nourmalaeb Mar 3, 2026
46c69b4
simplify
nourmalaeb Mar 3, 2026
760649d
Improve rubricTemplate, less casting, more functional
nourmalaeb Mar 3, 2026
183600b
Show rubric preview at smaller breakpoints
nourmalaeb Mar 3, 2026
b50a2cb
Extract shared JSON Schema template utilities
nourmalaeb Mar 4, 2026
66e5075
Add typed rubricTemplateEncoder for better type safety
nourmalaeb Mar 4, 2026
176e53d
Move ConfirmDeleteModal to shared location
nourmalaeb Mar 4, 2026
6658990
Add Suspense and ErrorBoundary fallbacks to CriteriaSection
nourmalaeb Mar 4, 2026
19cc460
Use ProcessStatus enum instead of string literals
nourmalaeb Mar 4, 2026
259a3d8
Improve RubricCriterionCard styling and validation
nourmalaeb Mar 4, 2026
0d9585e
Improve RubricEditorContent typing and patterns
nourmalaeb Mar 4, 2026
663cdb5
Fix max points data loss with description caching
nourmalaeb Mar 4, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions apps/app/src/components/ConfirmDeleteModal.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
import { Button } from '@op/ui/Button';
import { Modal, ModalBody, ModalFooter, ModalHeader } from '@op/ui/Modal';

import { useTranslations } from '@/lib/i18n';

export function ConfirmDeleteModal({
isOpen,
title,
message,
onConfirm,
onCancel,
}: {
isOpen: boolean;
title: string;
message: string;
onConfirm: () => void;
onCancel: () => void;
}) {
const t = useTranslations();
return (
<Modal
isDismissable
isOpen={isOpen}
onOpenChange={(open) => {
if (!open) {
onCancel();
}
}}
>
<ModalHeader>{title}</ModalHeader>
<ModalBody>
<p>{message}</p>
</ModalBody>
<ModalFooter>
<Button
color="secondary"
className="w-full sm:w-fit"
onPress={onCancel}
>
{t('Cancel')}
</Button>
<Button
color="destructive"
className="w-full sm:w-fit"
onPress={onConfirm}
>
{t('Delete')}
</Button>
</ModalFooter>
</Modal>
);
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use client';

import { useFeatureFlag } from '@/hooks/useFeatureFlag';
import { trpc } from '@op/api/client';
import { ProcessStatus } from '@op/api/encoders';
import { Button } from '@op/ui/Button';
Expand Down Expand Up @@ -87,6 +88,7 @@ const ProcessBuilderHeaderContent = ({
slug?: string;
}) => {
const t = useTranslations();
const rubricBuilderEnabled = useFeatureFlag('rubric_builder');
const router = useRouter();
const navigationConfig = useNavigationConfig(instanceId);
const { visibleSteps, currentStep, setStep } =
Expand Down Expand Up @@ -239,7 +241,9 @@ const ProcessBuilderHeaderContent = ({
className="flex h-full cursor-pointer items-center gap-2"
>
{t(step.labelKey)}
{step.id === 'rubric' && <ComingSoonIndicator />}
{step.id === 'rubric' && !rubricBuilderEnabled && (
<ComingSoonIndicator />
)}
</Tab>
))}
</TabList>
Expand All @@ -252,6 +256,7 @@ const ProcessBuilderHeaderContent = ({

const MobileSidebar = ({ instanceId }: { instanceId: string }) => {
const t = useTranslations();
const rubricBuilderEnabled = useFeatureFlag('rubric_builder');
const navigationConfig = useNavigationConfig(instanceId);
const { visibleSteps, currentStep, setStep } =
useProcessNavigation(navigationConfig);
Expand Down Expand Up @@ -293,7 +298,9 @@ const MobileSidebar = ({ instanceId }: { instanceId: string }) => {
className="flex h-8 items-center gap-2 bg-transparent selected:bg-neutral-offWhite"
>
{t(step.labelKey)}
{step.id === 'rubric' && <ComingSoonIndicator />}
{step.id === 'rubric' && !rubricBuilderEnabled && (
<ComingSoonIndicator />
)}
</Tab>
))}
</TabList>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use client';

import { trpc } from '@op/api/client';
import { ProcessStatus } from '@op/api/encoders';
import { useDebouncedCallback } from '@op/hooks';
import { SelectItem } from '@op/ui/Select';
import { useEffect, useRef } from 'react';
Expand All @@ -9,13 +10,12 @@ import { z } from 'zod';
import { useTranslations } from '@/lib/i18n';
import type { TranslateFn } from '@/lib/i18n';

import { SaveStatusIndicator } from '@/components/decisions/ProcessBuilder/components/SaveStatusIndicator';
import { ToggleRow } from '@/components/decisions/ProcessBuilder/components/ToggleRow';
import type { SectionProps } from '@/components/decisions/ProcessBuilder/contentRegistry';
import { useProcessBuilderStore } from '@/components/decisions/ProcessBuilder/stores/useProcessBuilderStore';
import { getFieldErrorMessage, useAppForm } from '@/components/form/utils';

import { SaveStatusIndicator } from '../../components/SaveStatusIndicator';
import { ToggleRow } from '../../components/ToggleRow';
import type { SectionProps } from '../../contentRegistry';
import { useProcessBuilderStore } from '../../stores/useProcessBuilderStore';

const AUTOSAVE_DEBOUNCE_MS = 1000;

const createOverviewValidator = (t: TranslateFn) =>
Expand Down Expand Up @@ -78,7 +78,7 @@ export function OverviewSectionForm({
const utils = trpc.useUtils();

const [instance] = trpc.decision.getInstance.useSuspenseQuery({ instanceId });
const isDraft = instance.status === 'draft';
const isDraft = instance.status === ProcessStatus.DRAFT;

// Store: used as a localStorage buffer for non-draft edits only
const instanceData = useProcessBuilderStore(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import { parseDate } from '@internationalized/date';
import { trpc } from '@op/api/client';
import { ProcessStatus } from '@op/api/encoders';
import type { PhaseDefinition, PhaseRules } from '@op/api/encoders';
import { useDebouncedCallback } from '@op/hooks';
import {
Expand All @@ -15,7 +16,6 @@ import {
import { AutoSizeInput } from '@op/ui/AutoSizeInput';
import { Button } from '@op/ui/Button';
import { DatePicker } from '@op/ui/DatePicker';
import { Modal, ModalBody, ModalFooter, ModalHeader } from '@op/ui/Modal';
import type { Key } from '@op/ui/RAC';
import { DisclosureStateContext } from '@op/ui/RAC';
import { DragHandle, Sortable } from '@op/ui/Sortable';
Expand All @@ -33,12 +33,12 @@ import {

import { useTranslations } from '@/lib/i18n';

import { ConfirmDeleteModal } from '@/components/ConfirmDeleteModal';
import { RichTextEditorWithToolbar } from '@/components/RichTextEditor/RichTextEditorWithToolbar';

import { SaveStatusIndicator } from '../../components/SaveStatusIndicator';
import { ToggleRow } from '../../components/ToggleRow';
import type { SectionProps } from '../../contentRegistry';
import { useProcessBuilderStore } from '../../stores/useProcessBuilderStore';
import { SaveStatusIndicator } from '@/components/decisions/ProcessBuilder/components/SaveStatusIndicator';
import { ToggleRow } from '@/components/decisions/ProcessBuilder/components/ToggleRow';
import type { SectionProps } from '@/components/decisions/ProcessBuilder/contentRegistry';
import { useProcessBuilderStore } from '@/components/decisions/ProcessBuilder/stores/useProcessBuilderStore';

const AUTOSAVE_DEBOUNCE_MS = 1000;

Expand All @@ -49,7 +49,7 @@ export function PhasesSectionContent({
const [instance] = trpc.decision.getInstance.useSuspenseQuery({ instanceId });
const instancePhases = instance.instanceData?.phases;
const templatePhases = instance.process?.processSchema?.phases;
const isDraft = instance.status === 'draft';
const isDraft = instance.status === ProcessStatus.DRAFT;

// Store: used as a localStorage buffer for non-draft edits only
const storePhases = useProcessBuilderStore(
Expand Down Expand Up @@ -489,40 +489,15 @@ export const PhaseEditor = ({
<LuPlus className="size-4" />
{t('Add phase')}
</Button>
<Modal
isDismissable
<ConfirmDeleteModal
isOpen={phaseToDelete !== null}
onOpenChange={(open) => {
if (!open) {
setPhaseToDelete(null);
}
}}
>
<ModalHeader>{t('Delete phase')}</ModalHeader>
<ModalBody>
<p>
{t(
'Are you sure you want to delete this phase? This action cannot be undone.',
)}
</p>
</ModalBody>
<ModalFooter>
<Button
color="secondary"
className="w-full sm:w-fit"
onPress={() => setPhaseToDelete(null)}
>
{t('Cancel')}
</Button>
<Button
color="destructive"
className="w-full sm:w-fit"
onPress={confirmRemovePhase}
>
{t('Delete')}
</Button>
</ModalFooter>
</Modal>
title={t('Delete phase')}
message={t(
'Are you sure you want to delete this phase? This action cannot be undone.',
)}
onConfirm={confirmRemovePhase}
onCancel={() => setPhaseToDelete(null)}
/>
</div>
);
};
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use client';

import { trpc } from '@op/api/client';
import { ProcessStatus } from '@op/api/encoders';
import type { ProposalCategory } from '@op/common';
import { useDebouncedCallback } from '@op/hooks';
import { Button } from '@op/ui/Button';
Expand All @@ -14,9 +15,9 @@ import { LuLeaf, LuPencil, LuPlus, LuTrash2 } from 'react-icons/lu';

import { useTranslations } from '@/lib/i18n';

import { ensureLockedFields } from '../../../proposalTemplate';
import type { SectionProps } from '../../contentRegistry';
import { useProcessBuilderStore } from '../../stores/useProcessBuilderStore';
import type { SectionProps } from '@/components/decisions/ProcessBuilder/contentRegistry';
import { useProcessBuilderStore } from '@/components/decisions/ProcessBuilder/stores/useProcessBuilderStore';
import { ensureLockedFields } from '@/components/decisions/proposalTemplate';

const AUTOSAVE_DEBOUNCE_MS = 1000;
const CATEGORY_TITLE_MAX_LENGTH = 40;
Expand All @@ -36,7 +37,7 @@ export function ProposalCategoriesSectionContent({

// Fetch server data for seeding
const [instance] = trpc.decision.getInstance.useSuspenseQuery({ instanceId });
const isDraft = instance.status === 'draft';
const isDraft = instance.status === ProcessStatus.DRAFT;
const serverConfig = instance.instanceData?.config;

const storeData = useProcessBuilderStore(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,32 +5,30 @@ import { Suspense } from 'react';

import { useTranslations } from '@/lib/i18n';

import type { SectionProps } from '../../contentRegistry';
import ErrorBoundary from '@/components/ErrorBoundary';
import { ErrorMessage } from '@/components/ErrorMessage';
import type { SectionProps } from '@/components/decisions/ProcessBuilder/contentRegistry';

import { CodeAnimation } from './RubricComingSoonAnimation';
import { RubricParticipantPreview } from './RubricParticipantPreview';
import { DUMMY_RUBRIC_TEMPLATE } from './dummyRubricTemplate';
import { RubricEditorContent } from './RubricEditorContent';
import { RubricEditorSkeleton } from './RubricEditorSkeleton';

export default function CriteriaSection(props: SectionProps) {
return (
<Suspense>
<CriteriaSectionContent {...props} />
</Suspense>
<ErrorBoundary fallback={<ErrorMessage />}>
<Suspense fallback={<RubricEditorSkeleton />}>
<CriteriaSectionContent {...props} />
</Suspense>
</ErrorBoundary>
);
}

function CriteriaSectionContent(_props: SectionProps) {
function CriteriaSectionContent(props: SectionProps) {
const t = useTranslations();
const rubricBuilderEnabled = useFeatureFlag('rubric_builder');

if (rubricBuilderEnabled) {
return (
<div className="flex h-full flex-col md:flex-row">
{/* Left panel — placeholder for the future rubric builder */}
<main className="flex-1 basis-1/2 overflow-y-auto p-4 pb-24 md:p-8 md:pb-8" />

<RubricParticipantPreview template={DUMMY_RUBRIC_TEMPLATE} />
</div>
);
return <RubricEditorContent {...props} />;
}

return (
Expand Down
Loading
Loading