Fix excessive Redis log spam when Redis is unavailable#649
Draft
valentin0h wants to merge 2 commits intodevfrom
Draft
Fix excessive Redis log spam when Redis is unavailable#649valentin0h wants to merge 2 commits intodevfrom
valentin0h wants to merge 2 commits intodevfrom
Conversation
Replace per-event error logging with state-based transition logging. A redisAvailable flag tracks connectivity so get/set short-circuit silently when Redis is down, and only one log line is emitted per state change instead of per retry and per request.
The previous cap of 3 retries meant Redis was permanently disabled for the process lifetime after any outage. With the redisAvailable guard already short-circuiting get/set, retries cost nothing — just backoff up to 30s so the ready event can fire when Redis comes back.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get()andset()now short-circuit immediately when Redis is known to be unavailable, eliminating per-request error noise.connect()rejection since theerrorevent handler already covers the transitionBefore
Every Redis retry (up to 5 per cycle) and every API request hitting
cache()while Redis was down produced a fulllogger.error()with stack trace — hundreds of lines per minute during local dev.After
A single
[WARN] Redis connection lost — cache operations will fall through to DBwhen Redis goes down, and[INFO] Redis connectedwhen it comes back. Zero noise in between.