Add JWT authentication for Tiptap collaboration on proposals#606
Draft
valentin0h wants to merge 9 commits intodevfrom
Draft
Add JWT authentication for Tiptap collaboration on proposals#606valentin0h wants to merge 9 commits intodevfrom
valentin0h wants to merge 9 commits intodevfrom
Conversation
Users can only access collaboration documents for proposals where they have profile-level READ access (via profileUsers table). The server generates a scoped JWT containing allowedDocumentNames so Tiptap Cloud enforces per-document access control.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
READ permission allowed read-only users to receive a write-capable JWT, bypassing the UPDATE gate enforced by updateProposal.
When Tiptap Cloud rejects an expired or invalid JWT, the handler invalidates the token query so React Query refetches a fresh token, which triggers the provider to reconnect.
Refetches the token every 12 hours so the 24h JWT is refreshed well before expiry, preventing silent disconnects for long sessions.
Moves DB lookup, authorization, and token generation out of the tRPC handler into a service function, matching the pattern used by every other proposal endpoint. Now uses assertInstanceProfileAccess with org-level fallback instead of a bare checkPermission call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hardcoded
notokenplaceholder in the Tiptap collaboration provider with proper JWT authentication, so collaborative editing is actually secured per-user and per-document.