Conversation
We can rewrite symlinks to ensure they are always relative and remain within the extraction directory.
fd0365f to
cd167e8
Compare
We can rewrite symlinks to ensure they are always relative and remain within the extraction directory.
qkaiser
left a comment
There was a problem hiding this comment.
I'll mark the PR as draft until ruff is back and we have a cleaner view on what are the logic changes being applied.
|
I believe there is still a bug in b11fe46: when extracting in a (host) directory within |
|
@qkaiser I wanted to make this PR just to have a place to discuss. It was extracted from a larger PR, and wanted to see CI test results, which our code checks (ruff) prevented, to push through the commit I have made some hacky fixes to be thrown away in the final version. This definitely needs a rewrite, so should have made it draft initially. I do not plan working on this soon, especially as the |
fe05dec to
064e1ad
Compare
Split off of #763 . There are still problems to solve here, see 954c1cd#commitcomment-138623089 but tests should run with the exception of 2 failures.