Conversation
2f4a1f0 to
bb3cb91
Compare
aef2486 to
8ade0a7
Compare
Contributor
Author
|
Re xpass tests in CI: It looks like there is some environment/python version specific behavior |
qkaiser
reviewed
Mar 20, 2026
Contributor
|
Interesting behavior:
|
qkaiser
reviewed
Mar 20, 2026
be97700 to
200fc88
Compare
- It runs only when `e2e` marker is passed (and in CI) - current error cases are marked with xfail tests if they were to pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e2emarker is passed (and in CI)In preparation for #1426, added a few end-to-end tests to assert on what behavior we want.
In a couple of sentences:
For SIGINT handling, pexpect is used to simulate terminal behavior, when CTRL-C being propagated to all members of the foreground process group