move e2fsprogs dependency from fork to upstream#1254
Conversation
|
|
|
It is very strange, that the failure https://github.com/onekey-sec/unblob/actions/runs/17400208989/job/49391774625?pr=1254#step:5:1047 happens only in one of the python environments, not all of them. |
It's affecting all of them, it's just that the others got cancelled. If a failure is observed in one of the tests, the others are cancelled. |
we may run the tests inside docker or force install e2fsprogs from debian |
qkaiser
force-pushed
the
1252-fix-e2fsprogs-dependency
branch
8 times, most recently
from
95e44c1 to
a221185
Compare
|
Chose to run tests in docker container with Ubuntu 25.10 but building dev dependencies (taplo, specifically) is .. difficult. |
qkaiser
force-pushed
the
1252-fix-e2fsprogs-dependency
branch
3 times, most recently
from
7867a75 to
4221e65
Compare
|
We need this #1368 first |
qkaiser
force-pushed
the
1252-fix-e2fsprogs-dependency
branch
4 times, most recently
from
10dc348 to
d24edae
Compare
qkaiser
force-pushed
the
1252-fix-e2fsprogs-dependency
branch
2 times, most recently
from
3a04593 to
40e7bc1
Compare
Our debugfs fix¹ is present in the debian trixie version² and in latest Ubuntu³. We can therefore go back to installing it from upstream rather than relying on our own fork. ¹: tytso/e2fsprogs@56a444e ²: https://metadata.ftp-master.debian.org/changelogs//main/e/e2fsprogs/e2fsprogs_1.47.2-3_changelog ³: https://launchpad.net/ubuntu/+source/e2fsprogs
This reverts commit c13a053.
qkaiser
force-pushed
the
1252-fix-e2fsprogs-dependency
branch
11 times, most recently
from
90197a2 to
00d6416
Compare
qkaiser
force-pushed
the
1252-fix-e2fsprogs-dependency
branch
from
00d6416 to
990c497
Compare
3 participants
Our debugfs fix is present in the debian trixie version and in latest Ubuntu. We can therefore go back to installing it from upstream rather than relying on our own fork.
Which means we can revert c13a053 and move to Debian Trixie for the Docker container.