💥 introduced register-unregister wallet in identity #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgonday
requested changes
Jan 5, 2026
pgonday
requested changes
Jan 21, 2026
| /// @notice Reverts if the factory is already registered | ||
| error AlreadyAFactory(address factory); | ||
|
|
||
| /// @notice Reverts when the recovered signer does not match the wallet being registered |
Collaborator
There was a problem hiding this comment.
Remove all these new errors which are not used anymore
contracts/factory/IdFactory.sol
Outdated
| signature | ||
| ); | ||
| require(error == ECDSA.RecoverError.NoError, Errors.InvalidSignature()); | ||
| require(signer == wallet, Errors.InvalidSignature()); |
Collaborator
There was a problem hiding this comment.
Use a single statement with && and use existing ECDSA.ECDSAInvalidSignature error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.