lambda-image-republish: Digest change should trigger update#30
Open
dwhswenson wants to merge 2 commits intoomsf:mainfrom
Open
lambda-image-republish: Digest change should trigger update#30dwhswenson wants to merge 2 commits intoomsf:mainfrom
dwhswenson wants to merge 2 commits intoomsf:mainfrom
Conversation
This handles the case that user deploys with tag "latest", and expects a future update to pull in the newest "latest." Note that we recommend using immutable tags, but my intuition is that if someone chooses "latest," then they probably want to autoupdate when they do a new plan. I don't particularly like this implementation, but from what I can tell, the aws_ecr_image doesn't work on public repositories, and there's no equivalent in aws_ecrpublic until provider version 6.19. Unfortunately, I'm still stuck on 4.x for local reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles the case that user deploys with tag "latest", and expects a future update to pull in the newest "latest."
Note that we recommend using immutable tags, but my intuition is that if someone chooses "latest," then they probably want to autoupdate when they do a new plan.
I don't particularly like this implementation, but from what I can tell, the aws_ecr_image doesn't work on public repositories, and there's no equivalent in aws_ecrpublic until provider version 6.19. Unfortunately, I'm still stuck on 4.x for local reasons.
EDIT: Switched out an ugly shell script implementation for using a 3rd party Docker provider. Still not my favorite, but not as bad as the original approach.