parse JSON instead of load JSON #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

midnight-wonderer wants to merge 1 commit into omise:master from midnight-wonderer:bug/server-error-not-rescuable

midnight-wonderer commented Oct 18, 2024 •

edited

Loading

Description

Issue ID: Could you use JSON.parse instead of JSON.load? #60

Decision(s)

JSON.load does not raise rescue-friendly errors. (See #60.)
Use JSON.parse like everyone else.

Business impact (if any)

When the exception is rescued properly, the business interruption is prevented.


          parse JSON instead of load JSON

32c7c26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet