Improve Windows Build Reliability with Smarter Npcap SDK Resolution#1
Open
manucian-official wants to merge 1 commit intoomerarslan0:mainfrom
Open
Improve Windows Build Reliability with Smarter Npcap SDK Resolution#1manucian-official wants to merge 1 commit intoomerarslan0:mainfrom
manucian-official wants to merge 1 commit intoomerarslan0:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Improve Windows Npcap SDK Detection in build.rs
🧠 Overview
This update refactors the
emit_windows_packet_sdk_linkslogic to make Npcap SDK detection more robust, maintainable, and cross-architecture compatible.⚡ Key Improvements
🔥 1. Smarter SDK Discovery
NPCAP_SDK_DIRenvironment variable (highest priority)../npcap-sdk/Lib)ProgramFiles/ProgramFiles(x86)auto-detectionHashSet⚙️ 2. Architecture-Aware Linking
x86,x86_64)x64,x86)💎 3. Cleaner & Modular Code
has_required_libs()→ validates SDK presencearch_subdir()→ resolves architecture-specific paths🧪 4. Better Build Diagnostics
cargo:warningmessages when:🚀 5. Safer Platform Handling
cfg!(target_os = "windows")instead of runtime env checks📦 Behavior
Packet.libwpcap.libcargo:rustc-link-searchautomatically💡 Why This Matters
🔧 Optional Follow-ups
libpcapauto-detection