Add support for different configurations#1
Open
jbockler wants to merge 2 commits intoomensinger:masterfrom
Open
Add support for different configurations#1jbockler wants to merge 2 commits intoomensinger:masterfrom
jbockler wants to merge 2 commits intoomensinger:masterfrom
Conversation
Add `Rk.configure` which accepts a name that will create `name_rk`. You can create multiple rk configurations with that if you need the keys in different formats. Remove date from gemspec since it gets automatically added when building the gem Add development dependencies to gemspec for dev setup via: `gem install --development rk` Fix bug that it was not possible to ask rk for configurations options (separator, prefix & suffix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Rk.configurewhich accepts a name that will createname_rk. You can create multiple rk configurations with that if you need the keys in different formats.Remove date from gemspec since it gets automatically added when building the gem
Add development dependencies to gemspec for dev setup via:
gem install --development rkFix bug that it was not possible to ask rk for configurations options (separator, prefix & suffix)
The app i am currently working on is connected to two different redis databases. Unfortunately both use a different format for the keys. I would like to use this gem, since i enjoyed using it in the past. But due to the global configuration it wasn't possible.
With my changes it is now possible to create different named configurations:
I tried not to create breaking changes. It should be totally fine to use rk just as before. The only change that may break something is that calling rk with a non existing key now returns a NoMethodError instead of a runtime error.
Let me know what you think about this. If you like it, i can change the README too.