Open
Conversation
Member
|
I think the filter itself is probably a good idea, but I don't want to make it the default as you have here. |
Author
|
should i make another pull request? |
Member
|
A different pull request is probably the best option. You can also just force-push to the branch you're using for the PR and that will update this one, but since you're on your master, it's probably best to just make a new one on a different branch. I recommend you split it up: the filter by itself first, then the UI pieces like links and buttons and possible default selections in a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in admin view, exhibits from all users are shown. There is no support for users to see their own exhibits only, which could be a very useful feature. With this pull request we introduce a new filter 'owner' to let users filter their own exhibits. There still remains an option to view exhibits from other users.