Skip to content

Added 2 extra columns + sortability to files list #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DBinaghi wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added 2 extra columns + sortability to files list #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2bbfbe
Added 2 extra columns + sortability to files list
DBinaghi Jun 19, 2020
dc8c901
Added extra info to $filenames array
DBinaghi Jun 19, 2020
d443622
Added localization of file size + lowercased file extension
DBinaghi Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion helpers/DropboxFunctions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ function dropbox_dir_list($directory)

foreach ($iter as $fileEntry) {
if ($fileEntry->isFile()) {
$filenames[] = $fileEntry->getFilename();
$filenames[] = array(
$fileEntry->getFilename(),
$fileEntry->getExtension(),
$fileEntry->getSize()
);
}
}

Expand Down
31 changes: 28 additions & 3 deletions views/admin/index/dropboxlist.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,23 @@ function dropboxNoEnter(e) {

jQuery('.dropbox-js').show();
jQuery('#dropbox-show-all').hide();

jQuery('th').click(function(){
var table = jQuery(this).parents('table').eq(0)
var rows = table.find('tr:gt(0)').toArray().sort(comparer(jQuery(this).index()))
this.asc = !this.asc
if (!this.asc){rows = rows.reverse()}
for (var i = 0; i < rows.length; i++){table.append(rows[i])}
})
});

function comparer(index) {
return function(a, b) {
var valA = getCellValue(a, index), valB = getCellValue(b, index)
return jQuery.isNumeric(valA) && jQuery.isNumeric(valB) ? valA - valB : valA.toString().localeCompare(valB)
}
}
function getCellValue(row, index){ return jQuery(row).children('td').eq(index).text() }
</script>

<p class="dropbox-js" style="display:none;">
Expand All @@ -70,13 +86,22 @@ function dropboxNoEnter(e) {
</colgroup>
<thead>
<tr>
<th><input type="checkbox" id="dropbox-select-all" class="dropbox-js" style="display:none"></th>
<th><?php echo __('File Name'); ?></th>
<th><input type="checkbox" id="dropbox-select-all" class="dropbox-js" style="display:none"></th>
<th><?php echo '<a>' . __('File Name') . '</a>'; ?></th>
<th style="text-align: center"><?php echo '<a>' . __('File Type'). '</a>'; ?></th>
<th style="text-align: center"><?php echo '<a>' . __('File Size'). '</a>'; ?></th>
</tr>
</thead>
<tbody id="dropbox-file-checkboxes">
<?php foreach ($fileNames as $fileName): ?>
<tr><td><input type="checkbox" name="dropbox-files[]" value="<?php echo html_escape($fileName); ?>"/></td><td><?php echo html_escape($fileName); ?></td></tr>
<tr>
<td><input type="checkbox" name="dropbox-files[]" value="<?php echo html_escape($fileName[0]); ?>"/></td>
<td><?php echo html_escape($fileName[0]); ?></td>
<td style="text-align: center"><?php echo strtolower(html_escape($fileName[1])); ?></td>
<td style="text-align: right">
<?php echo Zend_Locale_Format::toNumber($fileName[2]) . " B"; ?>
</td>
</tr>
<?php endforeach; ?>
</tbody>
</table>
Expand Down