Zendified code, fixed controller bugs and upgraded Readme.#27
Open
Daniel-KM wants to merge 5 commits intoomeka:masterfrom
Open
Zendified code, fixed controller bugs and upgraded Readme.#27Daniel-KM wants to merge 5 commits intoomeka:masterfrom
Daniel-KM wants to merge 5 commits intoomeka:masterfrom
Conversation
Author
|
Hi, I ended to fix this plugin (even if there are still some ajax related issues in admin view). I added a similar one for free tagging. Sincerely, Daniel Berthereau |
Daniel-KM
force-pushed
the
Zendification
branch
3 times, most recently
from
9643fc4 to
1e7bf70
Compare
Author
|
Hi, I have rebased the plugin on the last master commit and split previous commits into simpler ones. Sincerely, Daniel Berthereau |
Daniel-KM
force-pushed
the
Zendification
branch
from
1e7bf70 to
664aad8
Compare
Conflicts: CommentingPlugin.php
Daniel-KM
force-pushed
the
Zendification
branch
from
664aad8 to
60d59d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I find some bugs in controller and when I try to fix them, I needed to clean code before... Furthermore, the readme was for Omeka 1.5 and wasn't adapted.
Sincerely,
Daniel Berthereau
Infodoc & Knowledge management