Skip to content

Conversation

@Daniel-KM
Copy link
Contributor

A fix for the version v3 of box/spout.

@zerocrates
Copy link
Contributor

What's the problem currently when there are blank rows? What gets skipped?

@Daniel-KM
Copy link
Contributor Author

Not sure if this is the issue, but when csvimport meets a blank row, it may not return next rows.

@Daniel-KM
Copy link
Contributor Author

The issue occurs with the last version of box/spout, not v3.0.

@zerocrates
Copy link
Contributor

zerocrates commented Sep 29, 2021

I would guess that based on how the iterators and things work, if there were blank lines and the underlying iterator auto-skips them, you'd lose rows when moving to later "batches" as we try to skip to the correct starting point.

And for your clarification, this is only with a further updated version of spout than we're currently using? So maybe this fix should go along with such an update to the dependency (if that's needed). Or is the problem with a previous version?

@Daniel-KM
Copy link
Contributor Author

What is missing in many modules (and omeka in fact) is phpunit tests, so i have to check more to understand the issue i had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants