Add support for unicode strings #54
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to read a cell value in Excel that contained unicode data. I found that strings with non-ascii values seem to just return a blank string:
This pull request changes FromBstr/AsBstr to use UTF8, so that this now works as expected:
An alternative workaround that might be applicable for others is to use win32com.client via reticulate, but I didn't want to require a python installation:
I've also verified that writing unicode values works now with these changes also.
Note that there are still a bunch of places where we use non-encoding aware conversions, primarily around dispatch (method/property/type names etc), which I presume is fine. The focus here was on errors and values.
Let me know if there's some changes you'd want to see for this to be accepted. Thanks!