Update RDCOMClient #20
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first (minor) change was to make this an Rstudio package project, which made it easier for me to work with. Secondly, I changed a small section of converters.cpp. The call to UnList() was too heavy. When I returned a nested array like
{{1, 2}, {3, 4}}it was being flattened into
{1, 2, 3, 4}Removing that section resolved the issue, but of course, this no longer converts anything to R vectors automatically. I've found that calling unlist() in my R project code as needed is just fine. The other option would be to improve the logic of the if block.
numDims == 1 && rtype != -1wasn't quite right.Finally, I noticed that after rebuilding the package in 3.6.1, I was no longer getting the errors referenced in #19.
This change is