Skip to content

Conversation

@dkyleward
Copy link

@dkyleward dkyleward commented Jul 11, 2019

The first (minor) change was to make this an Rstudio package project, which made it easier for me to work with. Secondly, I changed a small section of converters.cpp. The call to UnList() was too heavy. When I returned a nested array like

{{1, 2}, {3, 4}}

it was being flattened into

{1, 2, 3, 4}

Removing that section resolved the issue, but of course, this no longer converts anything to R vectors automatically. I've found that calling unlist() in my R project code as needed is just fine. The other option would be to improve the logic of the if block. numDims == 1 && rtype != -1 wasn't quite right.

Finally, I noticed that after rebuilding the package in 3.6.1, I was no longer getting the errors referenced in #19.


This change is Reviewable

@gwd666
Copy link

gwd666 commented Jul 1, 2022

@dkyleward out of curiosity and judging by your comments do you "no longer" or "not" encounter

Error in createCOMReference(<pointer: 0x00000137dfcb6550>, "COMIDispatch") : 
  could not find function "createCOMReference"

issues?
I am using RDCOMClient in one of my packages and therefore on the lookout for a "newer" or "more current" version then the one I am currently building against (because I am forced to upgrade to R-4 now and running into all types of warnings and errors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants