generated from w3c-ccg/markdown-to-spec
-
Notifications
You must be signed in to change notification settings - Fork 62
RFC-3: review 1 #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clbarnes
wants to merge
3
commits into
ome:main
Choose a base branch
from
clbarnes:rfc3-review1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RFC-3: review 1 #420
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # RFC-3: Review 1 | ||
|
|
||
| ## Review authors | ||
|
|
||
| Chris Barnes <chris.barnes@gerbi-gmb.de> | ||
|
|
||
| ## Conflicts of interest | ||
|
|
||
| None. | ||
|
|
||
| ## Summary | ||
|
|
||
| This RFC is an important step towards opening up OME-Zarr to different types of bioimaging. | ||
| The current axes specification is already flexible enough that implementations cannot blindly make assumptions about what a particular dimension index means, | ||
| while being restrictive enough to be a bit annoying to write validation for. | ||
|
|
||
| This RFC represents an opportunity to simplify the spec and its implementations, | ||
| while serving a broader audience. | ||
|
|
||
| ## Significant comments and questions | ||
|
|
||
| N/A | ||
|
|
||
| ## Minor comments and questions | ||
|
|
||
| The current specification optimises for particular access patterns in terms of memory locality, | ||
| and the RFC already makes good points that these optimisations may not hold for other access patterns. | ||
| Because of the Zarr transpose codec, | ||
| the conceptual layout of the array may not match its on-disk layout, | ||
| making the utility of such optimisations even more hazy. | ||
| Lastly, with the introduction of the mapAxis transformation in RFC-5, | ||
| viewers may not even be retrieving array subsets which match the conceptual layout in zarr. | ||
|
|
||
| Users should have the freedom to design their array layouts to suit their own data and use cases, which this RFC allows. | ||
|
|
||
| ## Recommendation | ||
|
|
||
| Accept. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion (unrelated to content): In rfc5, I added reference anchors in the reviews like so:
which makes it easy to cross-reference across the ngff page in a controlled manner. But since this comment is likely going to be the end of a discussion rather than the start of it, you might as well ignore this :)