Skip to content

Rfc5 review response #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshmoore merged 120 commits into from
Oct 31, 2025
+2,016 −427
Merged

Rfc5 review response #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
120 commits
Select commit Hold shift + click to select a range
9f29c75
overhaul proposal
jo-mueller Oct 7, 2025
d2b7e7f
reply to reviews
jo-mueller Oct 7, 2025
a681c24
updated title and version date
jo-mueller Oct 7, 2025
c731cdb
reformatted authors table
jo-mueller Oct 7, 2025
557fd19
used myST references for cross-referencing
jo-mueller Oct 7, 2025
ceeea1c
clarification on process
jo-mueller Oct 7, 2025
3e076ed
added example for orientations metadata
jo-mueller Oct 7, 2025
2b52e95
removed reference to commit
jo-mueller Oct 7, 2025
4a588db
text style
jo-mueller Oct 7, 2025
a802f3b
Update index.md
jo-mueller Oct 7, 2025
1631604
answer question on affine transformation parsing
jo-mueller Oct 7, 2025
7d33ce4
fix rotation matrix dimensions
jo-mueller Oct 7, 2025
68b44dc
answered question on sample implementation
jo-mueller Oct 7, 2025
02dd25c
answered question on linking outside sources
jo-mueller Oct 7, 2025
adc1459
answer questions on units
jo-mueller Oct 7, 2025
5a25f00
added more information on `arrayCoordinateSystems`
jo-mueller Oct 7, 2025
9e73f80
justify breaking changes
jo-mueller Oct 7, 2025
84ce3b6
answer questions on parent-level transformations and input/output values
jo-mueller Oct 7, 2025
bd2287c
add entire `multiscales` section for completeness
jo-mueller Oct 7, 2025
d6ad74f
reorganized heading levels
jo-mueller Oct 7, 2025
9e783e9
Point out axis name uniqueness
jo-mueller Oct 7, 2025
bd9880e
added example to `coordinateSystems` metadata
jo-mueller Oct 7, 2025
a8db9d0
text style
jo-mueller Oct 7, 2025
091fd7f
add info on discretness
jo-mueller Oct 7, 2025
02f909a
text style
jo-mueller Oct 7, 2025
93a6a5a
text style
jo-mueller Oct 7, 2025
72ea8f0
added type hints to `coordinateTransformation` fields
jo-mueller Oct 7, 2025
aad15f6
text style
jo-mueller Oct 7, 2025
da043fa
added info to axes metadata
jo-mueller Oct 7, 2025
846a527
replaced zattrs by zarr.json
jo-mueller Oct 7, 2025
dd99be3
added and reformatted comprehensive example to coord. transforms
jo-mueller Oct 7, 2025
cb7f054
fixed header level
jo-mueller Oct 7, 2025
2057c49
typo
jo-mueller Oct 7, 2025
45a66ff
typo
jo-mueller Oct 7, 2025
d9aeeb2
recommend informative warning for unparsed transformations
jo-mueller Oct 7, 2025
5c67d81
added link to examples
jo-mueller Oct 7, 2025
fe5221d
Link out to examples
jo-mueller Oct 7, 2025
409d7e5
Removed abstract examples and update transform constraints
jo-mueller Oct 7, 2025
a7d2616
allow NULL values for optional `input`/`output` fields
jo-mueller Oct 8, 2025
5a9112b
removed duplicate sentence
jo-mueller Oct 8, 2025
45fa09c
removed request on feedback from updated proposal
jo-mueller Oct 9, 2025
59c46a5
added link to Zenodo repository for examples
jo-mueller Oct 10, 2025
57184d1
text style
jo-mueller Oct 10, 2025
a1bacf7
text style
jo-mueller Oct 10, 2025
cd32525
removed duplicate sentence
jo-mueller Oct 10, 2025
39cce64
text style and suggest selecting coordinate systems in viewers
jo-mueller Oct 10, 2025
e31574d
point out complementary nature of rfc5 and collections
jo-mueller Oct 10, 2025
d777903
remove generic requirement of `input` being a path
jo-mueller Oct 10, 2025
4ef4854
text style (directives instead of "")
jo-mueller Oct 10, 2025
c0f6463
amended replies to reviews to include links to other discussions.
jo-mueller Oct 10, 2025
9eca479
specified requirements for `input`/`output` in additional transforms
jo-mueller Oct 10, 2025
206575c
correct field name
jo-mueller Oct 10, 2025
2b8de8e
added cross-reference
jo-mueller Oct 10, 2025
c5ec41d
fixed name field
jo-mueller Oct 10, 2025
cb45aad
Text style and rewording
jo-mueller Oct 10, 2025
b0e48c4
teyt style
jo-mueller Oct 10, 2025
3b9ee1e
added reference to version title
jo-mueller Oct 10, 2025
5740e37
updated zenodo record
jo-mueller Oct 10, 2025
d0a7248
added replies to david
jo-mueller Oct 13, 2025
1cb709c
section on parameters stored in zarr arrays
bogovicj Oct 15, 2025
151ff44
Explain metadata duplication
jo-mueller Oct 15, 2025
449f782
text style
jo-mueller Oct 15, 2025
1559b7b
change `mapAxis` to integer list
jo-mueller Oct 15, 2025
3bcc49e
reformat `byDimension` requirements
jo-mueller Oct 15, 2025
a0d9179
text style
jo-mueller Oct 15, 2025
3f2e521
Added statement on zarr parameter storage discussion.
jo-mueller Oct 15, 2025
c76168e
Updated zenodo link to latest
jo-mueller Oct 15, 2025
cb58b64
remove statement that DOI-ed examples will be added
jo-mueller Oct 15, 2025
8c8994c
typos
jo-mueller Oct 15, 2025
0fdc5dd
fixed indendations and brackets in example
jo-mueller Oct 15, 2025
0144a68
minor formatting fixes
jo-mueller Oct 15, 2025
04f463b
expand on and edit reply re: inverseOf comment
bogovicj Oct 20, 2025
8a52423
typo
jo-mueller Oct 20, 2025
216b727
Semantic line breaks throughout proposal text
jo-mueller Oct 20, 2025
b891549
fix `transformation` reference for `inverseOf`
jo-mueller Oct 20, 2025
2e5e97a
correct inverseOf example
jo-mueller Oct 20, 2025
b0db747
text style
jo-mueller Oct 20, 2025
5d64472
correct plural for multiscales list
jo-mueller Oct 20, 2025
595cbc8
Removed deprecated statement about transformations in `byDimension` t…
jo-mueller Oct 21, 2025
4a75e4b
Clarify precedence of coordinateSystem over path
jo-mueller Oct 22, 2025
7532783
Merge branch 'rfc5-review-response' into rfc5-review-response
jo-mueller Oct 23, 2025
631a7c1
Merge pull request #1 from bogovicj/rfc5-review-response
jo-mueller Oct 23, 2025
afeeb98
Apply suggestions from code review
jo-mueller Oct 23, 2025
f121fd1
Minor text style
jo-mueller Oct 23, 2025
24379e6
update link to zarr arrays
jo-mueller Oct 23, 2025
b01148e
transformation matrices must be 2D
jo-mueller Oct 23, 2025
2fe869f
`input` in multiscales trafo MUST equal path
jo-mueller Oct 23, 2025
5b75f45
text style
jo-mueller Oct 23, 2025
cab8ef8
typos
jo-mueller Oct 23, 2025
a8f8713
add link to bijection forward/inverse to `inverseOf` description
jo-mueller Oct 23, 2025
eab1de2
fix example json
jo-mueller Oct 23, 2025
2d00d95
fix and add links
jo-mueller Oct 23, 2025
9fab599
text style
jo-mueller Oct 23, 2025
40982f7
Update rfc/5/versions/1/index.md
jo-mueller Oct 23, 2025
866ade3
Expanded example, moved down and added link
jo-mueller Oct 23, 2025
cb6d953
Merge branch 'rfc5-review-response' of https://github.com/jo-mueller/…
jo-mueller Oct 23, 2025
64e7f57
typo
jo-mueller Oct 23, 2025
a67e25d
Moved statement up
jo-mueller Oct 23, 2025
5d72413
renamed "default" to "intrinsic"
jo-mueller Oct 23, 2025
f1b651c
Improved wording on path/coordSys precedence in parent-level transforms
jo-mueller Oct 23, 2025
958c566
add WIll moore as endorser
jo-mueller Oct 23, 2025
f922e2d
add dstansby as endorser
jo-mueller Oct 23, 2025
89059e7
fix reference to .zarray
jo-mueller Oct 28, 2025
d3bb647
Moved updated proposal to front and legacy document into versions
jo-mueller Oct 29, 2025
6174a5e
Update rfc/5/index.md
jo-mueller Oct 29, 2025
f42eee0
use "zarr array" instead of "binary data"
jo-mueller Oct 29, 2025
8237047
add hint
jo-mueller Oct 30, 2025
f3ab357
added cross-references to trafo details in tabular view
jo-mueller Oct 31, 2025
a8ad5fd
clarify nesting convention
jo-mueller Oct 31, 2025
7f93e2c
correct scale values
jo-mueller Oct 31, 2025
72685be
Apply suggestions from code review
jo-mueller Oct 31, 2025
dd10ff6
extend recommendation to readers and viewers
jo-mueller Oct 31, 2025
94ec7fe
Merge branch 'rfc5-review-response' of https://github.com/jo-mueller/…
jo-mueller Oct 31, 2025
1687c6e
text style
jo-mueller Oct 31, 2025
e02ba89
Broaden statement about inclusivity of `input`/`output` fields
jo-mueller Oct 31, 2025
2962c7d
expand arrayCoordinateSystem example
jo-mueller Oct 31, 2025
dd082e6
typo
jo-mueller Oct 31, 2025
b7d9fae
Update rfc/5/index.md
jo-mueller Oct 31, 2025
ac3453f
Merge branch 'rfc5-review-response' of https://github.com/jo-mueller/…
jo-mueller Oct 31, 2025
e87d0c4
Update rfc/5/index.md
joshmoore Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading