Open
Conversation
…lementation - implement REGEX(text, pattern) function following Salesforce specification - handle Salesforce-style double-escaped backslashes (\\d becomes \d) - add 60 comprehensive test cases covering: * basic pattern matching and character classes * quantifiers, anchors, and groups * real-world validation patterns (email, phone, ZIP, SSN, credit cards) * error handling and edge cases - enhanced error messages with detailed JavaScript RegExp error information - all tests pass with proper linting and formatting resolves the requirement to add REGEX function to the formula engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
REGEXfunction was added tosrc/functions.tsto enable regular expression matching within formulas.REGEX(text, regex_pattern)was implemented to returntrueiftextmatchesregex_pattern, andfalseotherwise.\\din formulas). The implementation now preprocesses theregex_patternto convert\\\\to\before creating the JavaScriptRegExpobject, ensuring correct pattern interpretation.test/formula.test.ts.REGEXtests, are now passing, confirming the function's correct behavior and no regressions.