feat: bump apple-pim to 2.4.0, add COS profile integration#33
feat: bump apple-pim to 2.4.0, add COS profile integration#33omarshahine merged 4 commits intomainfrom
Conversation
- Bump marketplace version 2.0.0 → 2.0.1 - Bump apple-pim version 2.3.0 → 2.4.0 - Bump chief-of-staff version 2.0.0 → 2.0.1 - Add apple_pim_profile config field to settings.example.yaml - Add profile detection step to setup command (Phase 3) - Add "Apple PIM Profile Integration" section to README - Update SKILL.md with profile documentation Apple PIM v2.4.0 introduces multi-agent workspace profiles for filtered PIM access. Profiles are transparent at the MCP layer — configured via APPLE_PIM_PROFILE env var, no agent code changes needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PII Check FailedThe following potential PII was detected in this PR:
Please fix before merging. Use generic placeholders:
|
|
Claude finished @omarshahine's task in 1m 58s —— View job Code Review CompleteTasks:
Issues Found🔴 Critical: Marketplace Version MismatchThe Location: {
"name": "chief-of-staff",
"version": "2.0.0", // ❌ Should be 2.0.1
...
}According to CLAUDE.md versioning rules:
🟡 PII Check False PositiveThe CI flagged Root cause: The PII check pattern Options:
Since this blocks the PR merge, I recommend option 1 for now: What Looks Good ✓Version Bumps
Documentation Quality
Technical Accuracy
No Code Changes RequiredThe claim in the PR description is validated: "No COS agent code changes needed" — all changes are configuration and documentation. This is good separation of concerns. RecommendationsMust Fix Before Merge
Nice to Have (Future PRs)
SummaryThis is a solid PR that properly integrates Apple PIM v2.4.0 profile support into Chief-of-Staff. The documentation is clear and comprehensive, versioning follows semantic conventions, and backwards compatibility is maintained. Action Required: Fix the two issues above before merging. |
The PII scanner allowlist matches @example.com but not subdomains like @vendor.example.com. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The email allowlist pattern @example.com didn't match subdomains like @vendor.example.com. Updated to @([a-z0-9-]+\.)?example.com to allow both example.com and any subdomain of it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The marketplace plugin entry version must match the plugin's actual version per the versioning rules in CLAUDE.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
apple_pim_profileconfig field to COSsettings.example.yaml/chief-of-staff:setup(Phase 3)Context
Apple PIM v2.4.0 introduces PIMConfig shared Swift library with allowlist/blocklist filtering and multi-agent workspace profiles at
~/.config/apple-pim/profiles/{name}.json. Profiles are transparent at the MCP tool layer — the MCP server passesAPPLE_PIM_PROFILEas an env var to Swift CLIs. No COS agent code changes needed.Test plan
/mcpshows apple-pim MCP server loading/chief-of-staff:remindersstill creates reminders/chief-of-staff:setupdetects profiles when present at~/.config/apple-pim/profiles/🤖 Generated with Claude Code