Run parse_args before apply_filters in get_backend#770
Open
per-rtl wants to merge 1 commit intoolofk:mainfrom
Open
Run parse_args before apply_filters in get_backend#770per-rtl wants to merge 1 commit intoolofk:mainfrom
per-rtl wants to merge 1 commit intoolofk:mainfrom
Conversation
parse_args resolves command-line parameter overrides (e.g. --PARAM=val) into the EDAM parameters dict. Filters that need the resolved parameter values (such as elaboration-based lowering filters reading vlogparam defaults) see stale .core defaults when apply_filters runs first. Swap the order so filters always see the fully resolved parameter state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_argsandapply_filtersordering inget_backend()so that EDAM filters see fully resolved command-line parameter overridesparse_argsresolves command-line parameter overrides (e.g.--PARAM=val) into the EDAMparametersdict. Whenapply_filtersruns first, filters that readvlogparamdefaults (such as elaboration-based lowering filters) only see the.corefile defaults, not the user's command-line overrides.Test plan
test_edalizer.pytests pass (filter behaviour unchanged)--PARAM=valoverrides and an EDAM filter that reads parameter values