Closed
Conversation
There are quite a few cases of unused imports, and even some errors like undefined name. Ruff can be used to catch these going forward. For now, all failing lints are ignored. These can be ratcheted down in the future.
Ruff lint F523
Ruff lint F821
Ruff lint F841
Ruff lint F401
Owner
|
I don't have any opinions on what linter to use, but it looks like it picked up some nice clean-ups at least, so I'm happy to give it a go. Want to pull some other things in first though to avoid merge conflicts. |
Contributor
Author
|
Closing in favour of #763 |
Contributor
|
Sorry, did not notice your PR before I had almost finished with my changes :) |
Contributor
Author
|
No worries, pleased to see it being worked on! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a few problems in the code base that would have been picked up on by a linter.
I've added the ruff linter to
pre-commitand addressed some of the failures with simpler fixes.Do we think using ruff for linting is a good idea?