Print directory change notifications around tool execution#511
Merged
olofk merged 2 commits intoolofk:mainfrom Mar 30, 2026
Merged
Print directory change notifications around tool execution#511olofk merged 2 commits intoolofk:mainfrom
olofk merged 2 commits intoolofk:mainfrom
Conversation
Owner
|
Looks good. Wondering if you want to enable the same for the Flow API backends too in |
Contributor
Author
Seems like we should, will look into it. |
3 tasks
olofk
pushed a commit
that referenced
this pull request
Apr 1, 2026
Extends the Entering directory / Leaving directory notifications from Print directory change notifications around tool execution #511 to the Flow API's _run_tool() in edalize/flows/edaflow.py Adds unit tests covering both legacy and Flow API _run_tool() directory notifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Entering directory '...'andLeaving directory '...'around tool invocations in_run_tool()Motivation
When edalize runs a tool (e.g. slang for linting), it sets
cwd=self.work_root, so the tool reports file paths relative to the build directory. Editors that parse compiler output (like Emacscompilation-mode) cannot resolve these paths back to the source files.GNU Make solved this with
Entering directory/Leaving directorymessages. This patch adds the same convention to edalize so that editor integrations work out of the box.Test plan
fusesoc run --target=slanglint ...)Entering directoryandLeaving directoryappear in output