Load stocks widget component from staging, add to RHR#6
Open
egargan-ft wants to merge 1 commit intooliverturner:mainfrom
Open
Load stocks widget component from staging, add to RHR#6egargan-ft wants to merge 1 commit intooliverturner:mainfrom
egargan-ft wants to merge 1 commit intooliverturner:mainfrom
Conversation
This commit hackily reproduces the behaviour of the Extensible Frontends 'runtime' module, which pulls components from a registry and loads them onto the page. The stocks widget component is pulled from the stocks widget's staging component server, which at the time of writing hosts a hacked version of the widget that knows how to use the new 'cmd' attribute on the RHR element. You'll need to install a plugin to have the browser ignore the stocks widget server's CORS rules, I use the "Allow CORS" extension: just download it and activate it when you're in the demo app and it should all work fine!
✅ Deploy Preview for willowy-florentine-38731a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hackily reproduces the behaviour of the Extensible Frontends 'runtime' module, which pulls components from a registry and loads them onto the page.
The stocks widget component is pulled from the stocks widget's staging component server, which at the time of writing hosts a hacked version of the widget that knows how to use the new 'cmd' attribute on the RHR element.
You'll need to install a plugin to have the browser ignore the stocks widget server's CORS rules, I use the "Allow CORS" extension: just download it and activate it when you're in the demo app and it should all work fine!