Use grid with fixed-size rows vs flex for RHR region layout#1
Open
egargan-ft wants to merge 3 commits intooliverturner:mainfrom
Open
Use grid with fixed-size rows vs flex for RHR region layout#1egargan-ft wants to merge 3 commits intooliverturner:mainfrom
egargan-ft wants to merge 3 commits intooliverturner:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way RHR regions are laid-out, using a grid layout vs flex + space-around.
This change aims to prevent content moving around when new items are added "late" to RHR regions with available space, as will likely be the case for the stocks widget.
justify: space-arounddictates that child items will be positioned with even spacing between them. Using grid +grid-template-rows: repeat(auto-fill, 1080px);gives us a fixed set of region 'cells', meaning region items will not move around if another item is added to the region.