Application stop bug fix

lib/davis.app.js

@@ -138,6 +138,8 @@ Davis.App = (function () {
     }
 
     var handleRequest = function (request) {
+      if (!self.running) return;
+
       if (beforeFiltersPass(request)) {
         self.trigger('lookupRoute', request)
         var route = self.lookupRoute(request.method, request.path);
@@ -216,5 +218,25 @@ Davis.App = (function () {
     this.running = false
   };
 
+  /**
+   * Destroys the app.
+   *
+   * Stops the app and cleans itself from any DOM interaction bringing it back to an unconfigured state.
+   */
+  App.prototype.destroy = function() {    
+    this.stop();
+
+    if (this.boundToInternalEvents) {
+      this
+        .unbind('runRoute')
+        .unbind('routeNotFound')
+        .unbind('start')
+        .unbind('stop')
+        .unbind('routeError');
+
+      this.boundToInternalEvents = false;
+	}
+  };
+
   return App;
 })()

lib/davis.event.js

@@ -60,6 +60,20 @@ Davis.event = function () {
       handlers[i].apply(this, args)
     }
 
+    return this;
+  };
+
+ /**
+  * Unbinds all the callbacks from an event.
+  *
+  * @param {String} event event name
+  * @memberOf event
+  */
+  this.unbind = function (event) {
+    if (callbacks[event]) {
+      delete callbacks[event];
+    }
+
     return this;
   };
 }

tests/test_app.js

@@ -57,4 +57,19 @@ test("adding helpers to requests", function () {
 
   var req = factory('request')
   equal('bar', req.foo)
+})
+
+test("should cleanup internal events when stopped", function () {
+  var app = factory('app'),
+      unbindCount = 0;
+
+  app.unbind = function () {
+    unbindCount += 1;
+	return app;
+  }
+
+  app.start();
+  app.destroy();
+  ok(!app.boundToInternalEvents, "should set the internal events flag to false");
+  equals(unbindCount, 5, "should unbind every internal events");
 })

tests/test_event.js

@@ -37,4 +37,18 @@ test("passing data to an event handler", function () {
   same({foo: 'bar'}, callbackData, "should pass the callback data through to the handler");
   same({blah: 'halb'}, moreCallbackData, "should pass the callback data through to the handler");
   same(events, callbackContext, "should have this set to the app object");
-})
+})
+
+test("Unbindind an event", function () {
+  var events = factory('events'),
+      callbackCalled = false;
+
+  events.bind('foo', function () {
+    callbackCalled = true;
+  });
+
+  events.unbind('foo');
+  events.trigger('foo');
+
+  ok(!callbackCalled, "callback should have been unbound and not called when triggered");
+});