hash based routing, check for '/#' or '#' before adding it to a route#65
Open
evadnoob wants to merge 6 commits intoolivernn:masterfrom
Open
hash based routing, check for '/#' or '#' before adding it to a route#65evadnoob wants to merge 6 commits intoolivernn:masterfrom
evadnoob wants to merge 6 commits intoolivernn:masterfrom
Conversation
…eady containing '#' or '/#'
… spend much longer on it. When using forceHashRouting=true, upon the first load of Davis, the link selector event handler was running and causing issues with routes not being found. Seems like a load order problem where the hash routing plugin hadn't overriden enough functionality from base davis.js...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a small patch to hash based routing to prevent urls from getting extra '/#' prepended to them.
I've had links like:
And it in the url we sometimes see:
And a log message with routeNotFound
This patch fixes that problem....