-
-
Notifications
You must be signed in to change notification settings - Fork 7
Feat: 💫New paradigm to configure the Etl chain. #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oliverde8
wants to merge
15
commits into
master
Choose a base branch
from
feat/config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72dfcdd to
7786abe
Compare
…Finder and ExternalFileProcessor.
Co-authored-by: johbuch <johan.buchert@gmail.com>
0af5d6c to
2970ac0
Compare
Co-authored-by: johbuch <johan.buchert@gmail.com>
2970ac0 to
d67d788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library used php arrays until now to be configured. This was "logical" at the time with limiting typing in php and most frameworks using similar patterns with yaml being transformed into array.
The main issue with the array was/is writing it, keys and data are not easily identifiable without having to look into documentation. This means no autocomplete and no validation without running the code.
The purpose of here is to switch to a new pattern that will enable typing and auto completion from the IDE. This MR works on the Etl and not on the Rule engine which remains hard to configure.
TODO
[ ] Transform
Any merge request are welcomed
You can drop a comment on what
Additional Changes not related to this MR