Open
Conversation
brettz9
force-pushed
the
login
branch
2 times, most recently
from
f12628e to
0d98130
Compare
Author
|
I've updated my original post to indicate one fix to |
…es `post` method now; use non-deprecated token-retrieval) - Fix: Error not given to `_onError` promise when `response` is not an object - Git: Add `package-lock.json` to ignore file - npm: Update request - npm: Add recommended `package.json` fields (used on npmjs.com)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
login/edit/addissues (must be body only; request requirespostmethod now; use non-deprecated token-retrieval); it appears tokens are now always required_onErrorpromise whenresponseis not an objectpackage-lock.jsonto ignore filerequestpackage.jsonfields (used on npmjs.com)This should fix #5.
I didn't expose this
bodyOnlyAPI, though I could add a specialpostBodyOnlymethod for it if you wish. (I could have added it as an argument at the end ofpost, but I thought if you wanted to move to ES promises, then there would be no need forisPriority--justawaitor don'tawait, and then the API would get even more confused, so best to reevaluate I think at that time.)I haven't gotten into edit testing yet to know whether that is working. For example, I don't know whetherIt did; added to this commit_edit(used byeditandadd) will also need to use thebodyOnlyAPI.For some reasonWas my own issuebot.get({action: 'query', meta: 'tokens'})is not getting credentials for me despitejarbeing set to indicate the sending of cookies. But at least the issue with logging in appears to be resolved now with this PR.