Adding option to not expand events in GET request#244
Open
Conversation
osteele
reviewed
May 7, 2018
| self.assertEqual(response.status_code, 201) | ||
| self.assertEqual(response._status_code, 201) | ||
|
|
||
| def test_date_range(self): |
Contributor
There was a problem hiding this comment.
This code was moved to test_events.py. It looks like the change is the addition of the last subtest. It should go in that file instead of adding this method here.
osteele
suggested changes
May 7, 2018
Contributor
osteele
left a comment
osteele
left a comment
There was a problem hiding this comment.
Approved once the comment is addressed and it passes CI.
Contributor
|
Still good to go once the comment and CI failure are addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #57. Also adds a unit test for this functionality.