Minor warning fix, and improvement to transaction signing API #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lder (so you can load a transaction from a 3rd party, and sign it).
|
Can you add a code example please? I have exactly the same workflow |
Author
|
@caffeinum - If you pull this version you should be able to call the private method from wherever you need and pass in the values rather than a top level object. |
|
In case somebody stumbles upon this thread and is interested in the case, I implemented this differently: https://github.com/flightwallet/ios/blob/master/flight.wallet/Wallet/BitcoinWallet.swift#L276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found it necessary to sign a transaction that wasn't generated using the builder. Moved the transaction input signing functionality into BTCTransaction and exposed it there.
Tested:
Downloaded an unsigned transaction from coinb.in -- Signed it with my own private key -- Verified transaction was now signed correctly.